search

ProjectSidewalk / SidewalkWebpage

Project Sidewalk web page
http://projectsidewalk.org
MIT License
84 stars 25 forks source link

Can validate using keyboard shortcuts before start of 2nd or later missions #3704

Open misaugstad opened 4 weeks ago

misaugstad commented 4 weeks ago
Brief description of problem/feature

On both Validate and the new Validate pages, after you finish your second mission and then get to this mission start screen again: Screenshot from 2024-10-23 13-13-26

You can actually fully validate using the keyboard shortcuts without ever seeing the labels.

We correctly disable the keyboard while this mission complete screen is showing: Screenshot from 2024-10-23 13-17-52

But we're just re-enabling the keyboard too early!

jonfroehlich commented 4 weeks ago

Woah. Good catch! How did you figure this out?!

Sent from phone

On Wed, Oct 23, 2024 at 1:20 PM Michael Saugstad @.***> wrote:

Brief description of problem/feature

On both Validate and the new Validate pages, after you finish your second mission and then get to this mission start screen again: Screenshot.from.2024-10-23.13-13-26.png (view on web) https://github.com/user-attachments/assets/3a493567-7b44-4b1d-96f6-59d3d5238d29

You can actually fully validate using the keyboard shortcuts without ever seeing the labels.

We correctly disable the keyboard while this mission complete screen is showing: Screenshot.from.2024-10-23.13-17-52.png (view on web) https://github.com/user-attachments/assets/f13d13c6-ddbe-4caa-9da8-759e2f488625

But we're just re-enabling the keyboard too early!

— Reply to this email directly, view it on GitHub https://github.com/ProjectSidewalk/SidewalkWebpage/issues/3704, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAML55MGQBTTDJLXGRTJJJTZ5AAHBAVCNFSM6AAAAABQPTMRIGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYYDSNZVGAZTANA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

misaugstad commented 4 weeks ago

I was testing out something else w/ Validate so I was blowing through missions on a test server, forgot that I had to click through 2 screens between missions, but then saw that my accidental keyboard shortcut did something :eyes: