ProjectSidewalk / SidewalkWebpage

Project Sidewalk web page
http://projectsidewalk.org
MIT License
84 stars 25 forks source link

Creating new teams tab to be able to archive orgs and change visibility on leaderboard #3740

Open aslassi777 opened 6 days ago

aslassi777 commented 6 days ago

Resolves #3054

Implemented new teams tab for administrators to be able to "close" and "open" teams, which effects their visibility on the user dashboard of teams to join (except for admins). Also added ability to make teams "visible" and "non-visible" to be able to change visibility of teams on the leaderboard. Added in functionality to org table, some of the scala files, and had to add new routes.

Before/After screenshots (if applicable)

Before: I did not take a photo before developing teams page, and I currently do not have admin access to the real sidewalk page.

After:

Screenshot 2024-11-17 at 3 34 18 PM
Things to check before submitting the PR
misaugstad commented 6 days ago

Yess so exciting! Can't wait to take a closer look!!

I did not take a photo before developing teams page, and I currently do not have admin access to the real sidewalk page.

I think that the best way to do this anyway is to take the "before" screenshots on your local environment when running the develop branch! I usually take the "after" picture, then while I'm writing up the PR I switch back to the develop branch and take the "before" picture. It's honestly best to do it this way because it's a really direct comparison, both pics will be showing the same data since they're both from your dev env!

misaugstad commented 6 days ago

Again, so excited for this!!

And just from looking at the screenshot, let's call "Open/Closed" header "Status" and "Visible/Non-Visible" to "Visibility"! And is there any reason you didn't use the same styling for the drop down menus that we used for the other parts of the Admin page? I'd generally want to just keep things consistent between the different pieces of the Admin page! But ultimately it is just the Admin page, so it's okay to deviate if there's a reason!

aslassi777 commented 4 days ago

All good, I made the changes you requested. No reason not to make it similar to the other pages, so I took care of that in my most recent commit (updated photo so you can check out).