ProjectSidewalk / SidewalkWebpage

Project Sidewalk web page
http://projectsidewalk.org
MIT License
84 stars 25 forks source link

Pixelated GSV images introduced with #3626 #3762

Closed jonfroehlich closed 7 hours ago

jonfroehlich commented 8 hours ago

I just started using PS for the first time after #3626 and I noticed (to me), a big problem. The GSV window in PS is now pixelated regardless of browser window size or laptop screen size.

Take a look at what is now the PS view: image

vs. the actual GSV view: image

Notice how pixelated the road name and stop sign are. Something is happening with @jsomeara's code where it's not properly scaling the GSV window and, instead, is just doing a pixelated zoom. It makes everything on my monitor look grainy.

OK, here's zoomed in side-by-side comparison with PS on the left and GSV on the right. You should open the image in a new tab (or download it to zoom in and see details).

image

To me, this impacts not just the experience of PS auto-scaling on a large monitor 27" but also the experience when I'm using my MacBook Pro laptop (ordinary window size). The quality of the GSV imagery is reduced. Something is happening here.

Here's the location from above. Note: this is quite evident across two cities I tried and every pano I loaded.

City: Teaneck, NJ
Latitude: 40.90100188483349°
Longitude: -74.01587667926636°
Panorama ID: fCssctMO3cN2xzWNm4satA
Street ID: 1401
Region ID: 14
GSV URL: https://www.google.com/maps/@?api=1&map_action=pano&pano=fCssctMO3cN2xzWNm4satA&heading=267.2087500000017&pitch=-16.959999999999884
jonfroehlich commented 8 hours ago

Here's another example with PS on the left and GSV on the right. As before, you should open the image in a new tab (or download it to zoom in and see details). Check out the stop sign, the road sign (that says Kensington Rd. and Sussex Rd.—not even readable now in PS vs. quite legible in the original GSV imagery), the overall graininess of the house, the grass, etc.

image

City: Teaneck, NJ
Latitude: 40.90100188483349°
Longitude: -74.01587667926636°
Panorama ID: fCssctMO3cN2xzWNm4satA
Street ID: 1401
Region ID: 14
GSV URL: https://www.google.com/maps/@?api=1&map_action=pano&pano=fCssctMO3cN2xzWNm4satA&heading=121.14625000000171&pitch=-7.209999999999884

I would advocate for rolling back this "fix" until we figure this out. To me, it makes the labeling experience harder because the images are grainier and less high quality--and so it's harder to see things.

misaugstad commented 8 hours ago

And another problem, when I tried to look at this street directly using https://sidewalk-teaneck.cs.washington.edu/audit/street/1401, it's using auto-zoom! :joy:

misaugstad commented 7 hours ago

Reverted in #3763

Grainy vs clear: Screenshot from 2024-12-04 14-04-31 Screenshot from 2024-12-04 14-04-37