search

ProjectSidewalk / SidewalkWebpage

Project Sidewalk web page
http://projectsidewalk.org
MIT License
84 stars 24 forks source link

Jump often doesn't occur when a pop-up shows up during the jump operation #702

Open manaswisaha opened 7 years ago

manaswisaha commented 7 years ago

If you reach the end of route (i.e. "end of route" message shows up) and you completed the distance where the 'contributing a lot' message is triggered, the user is not jumped to the new location when the user clicks the jump message, and hence, pano doesn't change. But internally the new task is assigned, so the following "Uh-oh.." message shows up when user moves.

image

My hunch: It has to do with disabling interactions for pop-ups. Would have to look into if appropriate lock was obtained before jumping so that simultaneous operations such as the pop-up showing up (which disables interactions) doesn't interfere with the previous task.

FIX: The pop-up should be shown after the jump operation is completed.

jonfroehlich commented 7 years ago

Nice catch @manaswis. Should we also tag these things with a priority level or is anything tagged Relaunch Testing instantly high priority. :)

manaswisaha commented 7 years ago

Yep, high priority. :)

Unless there is a bug that we don't want to solve for Relaunch, we can mark them as priority low.

jonfroehlich commented 7 years ago

Unless there is a bug that we don't want to solve for Relaunch, we can mark them as priority low.

Agree.

jonfroehlich commented 5 years ago

I reached the end of a route and clicked on the bar in bottom right hand corner to 'jump to a new location' but I didn't actually jump. You can tell I didn't jump because the screen says I've been "moved to a new location" but you can see the labels that I had just added at that intersection.

image

Update: then I moved the mouse a bit (panned the GSV window) and then the 'Uh oh message' popped up:

image

@misaugstad, any thoughts?