ProjectSkyfire / SkyFire.406a

SkyFireEMU is a full featured F/OSS World of Warcraft: Cataclysm emulator written in C++. || Compatible with World of Warcraft client 4.0.6a (Build:13623) || Public DB is located on forum
http://www.projectskyfire.org
GNU General Public License v3.0
343 stars 218 forks source link

bugged chat #899

Closed F03SD closed 11 years ago

F03SD commented 11 years ago

When creating a new character in the frame does not have a chat channel.

F03SD commented 11 years ago

I'm sorry, I fix it

bool Player::CanJoinConstantChannelInZone(ChatChannelsEntry const* channel, AreaTableEntry const* zone) { if (channel->flags & CHANNEL_DBC_FLAG_ZONE_DEP && zone->flags & AREA_FLAG_ARENA_INSTANCE) { if ((channel->flags & CHANNEL_DBC_FLAG_CITY_ONLY) && (!(zone->flags & AREA_FLAG_SLAVE_CAPITAL))) return false;

    if ((channel->flags & CHANNEL_DBC_FLAG_GUILD_REQ) && GetGuildId())
        return false;
}

}

Bootz commented 11 years ago

How'd you miss that?

F03SD commented 11 years ago

I do not understand your question, I was referring to the fact that when creating a new character, they do not have chat channels

Bootz commented 11 years ago

wasn't really a question as much as a !!! where you said nevermind i fixed it...
that selection code is already in our core.. so i was like how'd you fix it if its already there... /shrugs i didnt understand your fix i suppose :pager:

F03SD commented 11 years ago

here http://pastebin.com/pmKwxYgB

Bootz commented 11 years ago

hmmz' i definitely see some spotted bad codestyling here... i will look into this fix or you can Pull Request it so others can see it, and it will get looked at faster.

F03SD commented 11 years ago

This is not a correction of a temporary solution, because I do not really know C + + but there is not always a variable Returns an (return), but the game behaves differently

F03SD commented 11 years ago

;) im test this