search

ProjectSkyfire / SkyFire.406a

SkyFireEMU is a full featured F/OSS World of Warcraft: Cataclysm emulator written in C++. || Compatible with World of Warcraft client 4.0.6a (Build:13623) || Public DB is located on forum
http://www.projectskyfire.org
GNU General Public License v3.0
343 stars 218 forks source link

Fix can't accept Quests for Worgen Quest Line #936

Closed Baeumchen closed 10 years ago

Baeumchen commented 10 years ago

This will fix, that you can't accept some Quests on Worgen Quest Line (start). Pull request as wished in commit:

https://github.com/ProjectSkyfire/SkyFireEMU/issues/853#issuecomment-24882571

SkyFire commented 10 years ago

Seems to work just fine. Merged.

Baeumchen commented 10 years ago

As i noticed there are even more Quests, which needs fixed. I tested the Night elf Starting area and there are the same Problem. Also i'm working on a new pet system. Primary i'll do the Pet system and while testing i'll do the Quests in the spawn areas... Will take a while :)

Raydeon commented 10 years ago

I don't think this is a proper fix... why would you change starting area quests to "sharable"? Flag 8 = sharable. These quests are NOT sharable. The quest flags for this particular quest are actually correct in the database. It should be flags 524288 (QUEST_FLAGS_AUTO_ACCEPT) + 262144 (QUEST_FLAGS_OBJ_TEXT) = 786432... which is what they are set at in the db before this fix. The problem is that skyfire's flags in the core are not correct. We should really revert this, as I personally sniffed every quest in the worgen area to get the correct flags and info during 4.0.6. The flags were right.

testingwalker commented 10 years ago

This was fixed the during the merge. I do agree with Raydeon, you don't want quest to be sharable in starting area, I believe the database in the skyfire's flag that needs fix.