search

ProjectSkyfire / SkyFire_548

SkyFireEMU is a full featured World of Warcraft: Mists of Pandaria emulator written in C++. || Compatible with World of Warcraft client 5.4.8 (Build: 18414) Project Established in 2011 || Support on Discord https://discord.gg/DnKZycD
http://www.projectskyfire.org
GNU General Public License v3.0
495 stars 422 forks source link

/p don't work in party mode, and writing /p in raid mod = /rw #440

Closed gegge6265 closed 9 years ago

gegge6265 commented 10 years ago

If i create a party and i chat in /p nothing will happen, my message won't be sent. Then i try to convert the party into raid: /raid WORKS /rw DOESN'T WORK /p IT WORKS like a /rw (see the screenshot)

(tested in gm on and gm off) wowscrnshot_081714_103853

Rawaho commented 10 years ago

Looks like an enum issue

rodrigoalv commented 10 years ago

the new form is for /stancy or something in spanish is /e in blizzard and u write direct to party or raid

Dr3adzor commented 10 years ago

I confirm this, /p doesn't work for party chat

c0per0 commented 10 years ago

in last commit chanel trade, and others don't work

ChipLeo commented 10 years ago

DEFINE_OPCODE_HANDLER(CMSG_MESSAGECHAT_PARTY, 0x109A, DEFINE_OPCODE_HANDLER(CMSG_MESSAGECHAT_RAID_WARNING, 0x109A, ..... :)

c0per0 commented 10 years ago

in party mode in my case don't work use the build 18414

ChipLeo commented 10 years ago

correct version {Opcode.CMSG_MESSAGECHAT_PARTY, 0x109A {Opcode.CMSG_MESSAGECHAT_RAID_WARNING, 0x16AB

Zerixx commented 10 years ago

Yeah so that makes RW and Party chat fixed.. I'd submit a PR if I were you, Gegge, or Chip.

gegge6265 commented 10 years ago

I'd like to but my pc was broken (this was the reason i don't log in irc for a lot of days), Now i bought a new pc, i have to install windows and all programs then if chip don't make a pr, i'll do it XD

Inviato da iPhone

Il giorno 29/ago/2014, alle ore 03:41, "Zerix" notifications@github.com ha scritto:

Yeah so that makes RW and Party chat fixed.. I'd submit a PR if I were you, Gegge, or Chip.

— Reply to this email directly or view it on GitHub.

Zerixx commented 9 years ago

Pretty easy to fix, just submit pr.