search

ProjectSkyfire / SkyFire_548

SkyFireEMU is a full featured World of Warcraft: Mists of Pandaria emulator written in C++. || Compatible with World of Warcraft client 5.4.8 (Build: 18414) Project Established in 2011 || Support on Discord https://discord.gg/DnKZycD
http://www.projectskyfire.org
GNU General Public License v3.0
499 stars 422 forks source link

[SPELL/MAGE] Counterspell #970

Open lingxDEV opened 4 years ago

lingxDEV commented 4 years ago

Current behaviour:

Counterspell the spell itself works as intended, however it can proc Touch of the Grave.

Expected behaviour:

Countspell shouldn't be able to proc Touch of the Grave, since it should only be procced by damaging spells.

Steps to reproduce the problem:

  1. Make a Mage
  2. Cast Counterspell over and over > see that you will proc Touch of the Grave at some point

SF rev. hash/commit:

Skyfire rev. 164451ca0b0b

SFDB version:

stable5

Operating system:

win10 64

lingxDEV commented 4 years ago

Further testing has shown that the problems lies with Touch of the Grave and not Counterspell in particular. All offensive spells can currently trigger Touch of the Grave. Need to make it only damaging abilities that can proc Touch of the Grave.