ProjectStarlight / StarlightRiver

Starlight River mod
https://discord.gg/snWQ3QE
GNU General Public License v3.0
145 stars 44 forks source link

The lighting buffers for SLR don't fully unload when reloading mods, causing a crash when trying to boot up a world after deactivating SLR and reloading mods #50

Closed Anarchy-9486 closed 2 years ago

Anarchy-9486 commented 2 years ago

Github issues should match the following format, for ease of organization and readability.

Issue Description

A thorough description of the problem, including: Expected behavior: I boot up a non-SLR world just fine Actual behavior: I get a crash with an error log Context: I had just unloaded SLR to test if the Endless Quiver Error message (if applicable): [01:20:47] [1/ERROR] [Terraria]: System.NullReferenceException: Object reference not set to an instance of an object. at StarlightRiver.Helpers.LightingBuffer.DebugDraw() in StarlightRiver\Helpers\LightingBuffer.cs:line 132

Reproduction

A detailed walkthrough of how to reproduce the issue, as thorough as possible. Mod list: HERO's Mod, Census, Recipe Browser, Boss Checklist, SLR (deactivated) Config settings: Default Game settings: White Lighting, if it even applies Gameplay events happening: Loading a non-SLR world Your inputs: After disabling SLR and reloading mods, I tried loading a world without any SLR content on a non-SLR character and got a crash OS: Windows 10

Additional context and log files

client.log

ScalarVector1 commented 2 years ago

Should be fixed in cbd9cd926876031bcfdc7edbf31fcb7b0f8240e8