ProjectStarlight / StarlightRiver

Starlight River mod
https://discord.gg/snWQ3QE
GNU General Public License v3.0
146 stars 43 forks source link

Mp item fixes #674

Closed TripleFate closed 7 months ago

TripleFate commented 8 months ago

I can't reproduce the softlocks that people have reported for the bossfights so instead I went through every obtainable item I'm aware of and checked them for mp compat. my hypothesis is that some other item / situation lead into the softlock failstate that people have reported. But since I haven't reproduced I really have no idea if thats the case.

Ideally we would have testers that would go through these items and report them so the devs don't have to iterate through everything like this but oh well. For example it would be nice if testers were to go though all the magic items in SLR and attempted to use them with the haunted armor in single and multiplayer to ensure it's robust.

fixed a handful of obvious bugs in the process and set a few projectiles that would make sense to use local / Id iframes

these are the only related issues I see on github that will be resolved with this:

653 #634 #633

ScalarVector1 commented 7 months ago

Looking amazing, only thing is to make sure to double check the seaglass lens -- I recall some strange behavior with crits not occuring even when forced on summon/sentry damage