ProjectStarlight / StarlightRiver

Starlight River mod
https://discord.gg/snWQ3QE
GNU General Public License v3.0
148 stars 44 forks source link

large and huge world vector packet fix #733

Closed TripleFate closed 4 months ago

TripleFate commented 4 months ago

packedVector2s cap out at 65535 and larger worlds can easily pass this on the x coordinate. went and replace all packedVector2s packets with normal Vector2s.

In theory we could go through and keep the ones that are relative vectors instead of world coordinates to save a few bytes, but I hate testing in huge worlds due to load time. So I think its more straight forward to just never use packedVector2s so we don't deal with this issue ever again even if it does cost some extra packet bytes.