search

ProjectTako / kparser

Automatically exported from code.google.com/p/kparser
1 stars 3 forks source link

Wrong parsing of damage if Monsters have same name. #62

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Solo at any camp with plenty of monsters with same name, like 
Steelshells or Colibris.
2. Someone else soloing also in same area as you.
3. You see message "[SomeoneElseName] defeats the [MonsterName]." on your 
log while you still actually fighting another monster.
4. After death of your monster, check KParser will display 2 monsters: one 
displayed as "[MonsterName](0)" with all the hits before the death message 
of the other guy, and other displayed as "[MonsterName](exp)" with all the 
hits after the death message of the other guy until the message where you 
received exp.
5. Consequence: That error when happened once in a parse isnot very 
harmful, can still retrieve the "0exp mob" from Raw Data. But when 
happened 10+ times in a parse, it's litterally mixing ALL monsters of 
different levels in same category [MonsterName](0), in other words, all 
hits recorded are pretty much lost.

What is the expected output? What do you see instead?
Expected output for example i know i hit average 25 hits on a Lesser 
Colibris with given gears/weapon. When checking KP, a few mob(s) have been 
killed with less than 10 hits lol (doing 0 WS) ...

What version of the product are you using? On what operating system?
The 3 last versions, i don't know for previous versions. WinVista32

Please provide any additional information below.
I <3 you, You are the man ! joking^^

Original issue reported on code.google.com by raphael.morineau@gmail.com on 30 Jan 2010 at 10:15

Attachments:

GoogleCodeExporter commented 8 years ago 
Examining the parse:

There are 13 fights that gave 0 XP.  Of those, only two fights register any 
damage at
all; fights 4 and 17.

All non-0XP fights show the birds have ~3400 - ~3600 HP (depending on level).  
Fights
4 and 17 are the exception in terms of approximate HP, with 2500 and 3200 
damage.

Reparsing with my current build shows 11 0XP fights.  A couple of 
-Unknowns-/false
kills are removed, including #4, though it looks like it got merged with fight 
#5.
#17 is now #16. Total damage for All fights remains identical.

Looking at the original data for fight #4, there's a gap where it looks like 
one bird
should have died, but no message for it shows up:

[2:32:03 PM] 
1d,7e,83,80443cd8,00001639,00001933,0034,00,01,02,00,ü[21:32:03]
The Lesser Colibri misses Masamunai.1
[2:32:06 PM] 
7a,00,00,80808010,0000163a,00001934,0031,00,01,02,00,ü[21:32:06]
Unable to see the Lesser Colibri.1
[2:32:06 PM] 
1c,7e,83,80b82024,0000163b,00001935,004a,00,01,02,00,ü[21:32:06]
The Lesser Colibri hits Masamunai for 56 points of damage.1
[2:33:46 PM] 
bf,00,00,60808080,00001653,00001950,0039,00,01,00,00,ü[21:33:46]
Masamunai's Retaliation effect wears off.1
[2:33:49 PM] 
65,68,4e,80504850,00001654,00001951,002b,00,01,02,00,ü[21:33:49]
Masamunai uses Retaliation.1
[2:36:35 PM] 
65,68,4e,80504850,00001655,00001952,0030,00,01,02,00,ü[21:36:35]
Masamunai uses Warrior's Charge.1
[2:36:36 PM] 
7b,03,00,60a02c34,00001656,00001953,0049,00,01,00,00,ü[21:36:36]
You cannot perform that action on the selected sub-target.
[2:36:40 PM] 
65,68,4e,80504850,00001657,00001954,0026,00,01,02,00,ü[21:36:40]
Masamunai uses Berserk.
[2:36:40 PM] 
65,68,4e,80504850,00001657,00001955,0039,00,01,02,00,ü[21:36:40]
Attacks are enhanced but defense weakens.1
[2:36:46 PM] 
14,43,83,80c08080,00001658,00001956,004b,00,01,02,00,ü[21:36:46]
Masamunai hits the Lesser Colibri for 115 points of damage.1

That explains that particular problem, which is not related to outside-party 
kills.

Fight 16 is thus the only 0 XP fight (killed by Karivar) with damage attached. 
Checking that..

Ok, fight 16 -should- have ended at 3:34 --

[3:34:16 PM] 
1c,f9,82,80b82024,000019f4,00001d89,004a,00,01,02,00,ü[22:34:16]
The Lesser Colibri hits Masamunai for 48 points of damage.1
[3:37:24 PM] 
bf,00,00,60808080,00001a08,00001da0,0039,00,01,00,00,ü[22:37:24]
Masamunai's Retaliation effect wears off.1

Clearly you stopped fighting after that point, but the data of the two fights 
will be
merged regardless.

There was a slight bug in determining entity types (due to later bug fixes in 
that
section not accounting for previous fixes in outside-party kills).  Fixing that
eliminates the bogus fight 16 data where Karivar defeats a bird.

There is now absolutely no damage recorded in the 0XP fights.  There are two 
fights
in that parse that are double-sized because of lack of any killshot message.

Bug marked fixed.

Original comment by Kinemati...@gmail.com on 6 Feb 2010 at 8:04