search

ProjectTorreyPines / SOLPS2ctrl.jl

Synthetic diagnostic workflow manager for use with SOLPS models
Apache License 2.0
2 stars 0 forks source link

Bug fix request: dd.equilibrium.time_slice[:].profiles_2d[:].psi transpose issue #15

Closed anchal-physics closed 1 year ago

anchal-physics commented 1 year ago

Please checkout bug_fix_req branch which has modified test for geqdsk_to_imas at 75ac548

If we use sample/ITER_Lore_2296_00000/EQDSK/g002296.00200 then the geqdsk file has unequal dimensions for the r and z grid. For this test case, geqdsk_to_imas test fails. This shows that there might be a transpose issue in setting up of dd.equilibrium.time_slice[:].profiles_2d[:].psi

Possible quick fix

Simply remove transpose at https://github.com/ProjectTorreyPines/SD4SOLPS.jl/blob/75ac548d0010c1bba08851690af7a458370edd68/src/SD4SOLPS.jl#L111

I'm not sure about this, so I would like @eldond to do this fix. Please verify the test on your machine and fix this.

eldond commented 1 year ago

Should be fixed by 546f5cdd50a1b5ad4f3d253411e4920ae26b4aa3, which also includes more rigorous testing for this issue.

anchal-physics commented 1 year ago

Fixed in https://github.com/ProjectTorreyPines/SD4SOLPS.jl/pull/16 and https://github.com/ProjectTorreyPines/SD4SOLPS.jl/pull/18