example/demo.ipynb appears to be out of date

ProjectTorreyPines / SOLPS2ctrl.jl

Synthetic diagnostic workflow manager for use with SOLPS models

Apache License 2.0

2 stars 0 forks source link

example/demo.ipynb appears to be out of date #45

Closed eldond closed 7 months ago

anchal-physics commented 8 months ago

@eldond What is the issue specifically? I can run the example/demo.ipynb file on my machine fine with correct set of sample files. However, I can see following possible improvements here:

Add dvc links for sample files so that they get pulled as well.
Add use of left_margin argument to stop clipping of y-axis label.
Add example of overlaying interferometer geometry on top of electron density heatmap.

eldond commented 7 months ago

Hold up, are you saying I should list specific problems or steps to reproduce or something?

Let me go figure out what went wrong.

eldond commented 7 months ago

Oh, the sample structure is out of date. The demo mentions

b2gmtry = "samples/b2fgmtry"
b2output = "samples/b2time.nc"
b2mn = "samples/b2mn.dat"

but they moved to sample/. Maybe it works for you because you have leftover files locally?

anchal-physics commented 7 months ago

Fixed in https://github.com/ProjectTorreyPines/SD4SOLPS.jl/pull/52