ProjectUnifree / unifree

MIT License
1.43k stars 75 forks source link

Wrong order for command line in documentation for Windows. #28

Closed jrronimo closed 11 months ago

jrronimo commented 12 months ago

In the documentation on the main page it says to run "launch.bat "

However, this errors out. I saw in the error output: ""python.exe" "C:\jrr-data\Documents\GitHub\unifree\unifree\free.py" -c "[my key]" -k "godot" -s "D:\Source\cocunity" -d "D:\Source\CoC-Godot-unifree""

-- I'm guessing -c is "config" and -k is "key", so the order should be: "launch.bat "

I tried this change and it does work for me, barring some errors in the %tmp% folder.

pRoFlT commented 12 months ago

i think launch.bat has the order flipped in the arguments. from what it says it should be.

set CONFIG_NAME=%1 <-- i flipped these on mine to keep layout the same. set OPENAI_API_KEY=%2 <-- set ORIGIN_DIR=%3 set DEST_DIR=%4

set USAGE_MSG="Usage: %0 "

should change it to set OPENAI_API_KEY=%1 set CONFIG_NAME=%2 so it aligns with error and with readme

StephenGrosjean commented 12 months ago

The order is indeed reversed, the working command is: 'launch.bat '

harryarakkal commented 11 months ago

Sorry about the confusion. The logs and logic have been updated to match the main README.md So the correct order is now: