Closed ProjectionWizard closed 4 years ago
Work on this has begun in branch 3-suggestions
.
See commit https://github.com/ProjectionWizard/projectionwizard.github.io/commit/4a078d52171df31e7617b2f3207ce4f28fec4445 which prevents a rectangle from being dragged too far north or south. This relates to the last item in the checklist above.
I just pushed several commits to branch 3-suggestions
. It includes fixes for the first, third, and last item in the checklist above. There are also some other additional fixes in this branch.
I added sliders to fix the second item in the checklist. @jwasilgeo, any opinions?
The sliders are a neat addition. What jquery ui lib are they coming from? I ask because the handle sizes a different and bigger here: https://jqueryui.com/slider/
Yes, sliders are from this jQuery lib. I modified their sizes to make them smaller. Thanks for fixing callback function. 👌 https://github.com/ProjectionWizard/projectionwizard.github.io/blob/d21a0f77a045eb4aa8ef2050f626591eed54f23a/page.css#L231-L237
See commit https://github.com/ProjectionWizard/projectionwizard.github.io/commit/e252993516343de3d10a391e64f5dad944c72b2a for the additional item on the list. @jwasilgeo, can you double check if it works for all cases?
Hey @beuan, thanks for working on that. I am revisiting the code and realize that what it needs is additional assignments of the variable activeProjection
so that the function highlightActiveProjectionNode
isn't trying to look up an incorrect DOM node. The var assignment wasn't used in enough places; for example ,when I do a find-all for activeProjection =
I get only 3 results among outputFormat.js and previewMap.js. Let me take another look at this.
Please let me know what you think about commit https://github.com/ProjectionWizard/projectionwizard.github.io/commit/bcef97923e72b1f5ef4d5412a1debb1439b5f420. Same effect, but helps the highlight node function to run in all cases with correct activeProjection
variable.
I also noticed some projection title nodes were <b>
, so I added font-weight: bold;
to the .active-projection
css class to make other projection title nodes that are <span>
have similar style. Maybe this is too much, if so, feel free to remove of course, Mr. 🗺️ 🧙 .
Having <b>
with style font-weight: bold
is a bit overkill, so for cases when only one projection is listed I replaced <b>
with <span>
. See https://github.com/ProjectionWizard/projectionwizard.github.io/commit/814567898f8ddcfb1f06fcfe8d4c3774c53f7637.
DONE
"active-projection"
CSS class is not being added to the projection info when there is only 1 projection available for certain projection recommendation conditions. Check current usage of the functionhighlightActiveProjectionNode
. (done in https://github.com/ProjectionWizard/projectionwizard.github.io/commit/e252993516343de3d10a391e64f5dad944c72b2a)