Adds sort, first and last

[Tpt]

@yhamoudi @Ezibenroc : Please review

[progval]

You only added sort in the description of the serialization

[Tpt]

@ProgVal You should read more carefully the diffs ;-)

[progval]

I did

[progval]

oh… oops…

[yhamoudi]

it would be nice to have more generic connectors than first/last... For example, how can i get the 3rd president of France?

[Tpt]

So, something like position(l, i) that would returns the ith element of l?

I think we should have first and last and maybe implement position later and make first(l) an alias for position(l, 1) et last(l) an alias of position(l, -1). But if you (ping @s-i-newton ) think that it would make the data model to heavy I'm ok to remove first and last and to implement position.

[yhamoudi]

yes, position(l,i) would be good, but it can be implemented later.

(i agree with the datamodel, you can merge)

[Ezibenroc]

Do you expect the Question Parsing modules to produce the sort constructor with a sentence such as Who is the first president of the United States??

[yhamoudi]

i don't if it's a question for me, but yes

[Ezibenroc]

No a question for Thomas. I know that we will never produce it...

[yhamoudi]

? it's easy (no joke)

[yhamoudi]

we get all US president with the subtree of root president. Then the node FIRST builds the sort node

[Tpt]

@yhamoudi @Ezibenroc Feel free to merge the pull request if you are ok with it

[Ezibenroc]

Yes but you don't know what we sort. Birth date? Death date? First names?

[Ezibenroc]

Ok for me.

[yhamoudi]

um, yes it's true

[progval]

Default to no predicate, and let Wikidata handle it?

[yhamoudi]

yes, i think wikidata could find a default predicate (the first date it finds for example)

[Ezibenroc]

:+1:

[yhamoudi]

so how to allow connector with no predicate in the datamodel (default predicate)?

[yhamoudi]

In the example:

+{

• "type": "sort",
• "list": [{"type": "resource", "value": "Theodore Roosevelt"}, {"type": "resource", "value": "George Washington"}] +}

The predicate is missing?

[Tpt]

"i think wikidata could find a default predicate": possible but far from easy. And I don't think to have time to support such thing before the presentation.