Closed progval closed 9 years ago
Seems good. Maybe we could also have an optionnal attribute for video URL?
I'm really not sure that it's relevant to allow the attributes for all resource types. I don't see what to output if there is a description with a geo-json resource, for example.
I would create a 'card' resource that extends the 'string' resource with these three attributes.
This would move the Wikipedia request from the WebUI to the Wikidata module (instant loading instead of ~0.5s)
But it may adds 0.5 seconds to the loading time of the result (more work in the Wikidata module side). So, not sure it's a good argument.
“But it may adds 0.5 seconds to the loading time of the result” -> the effect could be amortized using caching
I believe that all these use cases are covered by the resource-jsonld type introduced by pull request #44. So I close this one.
This is only a proposal and is totally open to debate. We should be at least three to agree on something before merging.
Possible improvements:
image
attributes of buttons optional. (Not sure this would give a good rendering on most UIs)Motivations: