Do not catch all Exceptions in requesthandler - Githubissues

ProjetPP / PPP-CAS

Computer Algebra System module for the Projet Pensées Profondes

MIT License

2 stars 3 forks source link

Do not catch all Exceptions in requesthandler #2

Closed progval closed 10 years ago

progval commented 10 years ago

Catching all exceptions (as you do here) is a bad style in Python, for several reasons:

It hides exceptions that might be important. (In that case, you might want to log them with logging.warning() before returning [])
It catches SIGTERMs (which are KeyboardInterrupt exceptions)
It may hide coding errors (ask @zorun if you want, he has a good story to tell you about that)