ProjetPP / PPP-QuestionParsing-Grammatical

Question Parsing module for the PPP using a grammatical approch
GNU Affero General Public License v3.0
33 stars 11 forks source link

“work” given as predicate for “what did terry pratchett write?” #138

Closed progval closed 9 years ago

progval commented 9 years ago

It should not be a predicate (neither should “works”), because it does not make sense (and is an alias for “occupation” on Wikidata).

http://askplatyp.us/?lang=en&q=what+did+terry+pratchett+write%3F

progval commented 9 years ago

And also, there is a regression because it used to be (?, author, Terry Pratchett)

Ezibenroc commented 9 years ago

(?, author, Terry Pratchett) is a subset of what we returns, since author is in the inverse predicate. There is no regression.

But I agree to remove work and works.

yhamoudi commented 9 years ago

I put them because they are properties used by wikidata to provide the books of an author (see http://www.wikidata.org/wiki/Property:P800 and http://www.wikidata.org/wiki/Q3335) but I will remove them if they are ambiguous.

(?, author, Terry Pratchett) is a subset of what we returns, since author is in the inverse predicate. There is no regression.

Yes, it would be nice to display the reverse predicates too on the UI

Ezibenroc commented 9 years ago

We could use notable works instead.

yhamoudi commented 9 years ago

Fix https://github.com/ProjetPP/PPP-QuestionParsing-Grammatical/commit/3771506e6177a1a3bd257f95aaa3372d04d1b764

progval commented 9 years ago

The Wikidata module does not support reverse-predicates, so the Platypus is broken on these searches :(

yhamoudi commented 9 years ago

I think it's the only query that appears in https://github.com/ProjetPP/PPP-WebUI/blob/master/questions.js and that cannot work without reverse predicates. We should remove it temporarily.

so the Platypus is broken on these searches :(

yes it's sad, but we cannot hardcode this question into the question parsing module. I let you lobby @Tpt so that reverse predicates are supported quickly by the wikidata module :)

Tpt commented 9 years ago

Support of reverse predicate is currently bocked by the fact that we need to be able to do fast queries (thing that WikidataQuery doesn't allow). I've nearly finished to implement queries into my custom EntityStore. The remaining things are to create indexes in the deployed database and to convert Wikidata module to use the EntityStore instead of Wikidata query.

So, if everything goes well (I'm not sure that MongoDB will be reactive enough with thousands of indexes) Wikidata module should be able to support reverse predicates within two weeks.

But if you want these things to go quicker, contributions are welcome!

progval commented 9 years ago

In the meantime, I reverted the version of the Grammatical used by the Platypus to 0.6.1.

yhamoudi commented 9 years ago

If it's just for "what did terry pratchett write?", we lose more questions that what we win...

progval commented 9 years ago

It's not just for Terry Pratchett