Closed Ezibenroc closed 8 years ago
Note: Travis fails because https://github.com/ProjetPP/Scripts/pull/7 is not yet merged.
There are some issues after updating bootstrap_corenlp.sh
: https://travis-ci.org/ProjetPP/PPP-QuestionParsing-Grammatical/jobs/118461688
That's because you copied the wrong version of bootstrap_corenlp.sh in the Deployment repository : https://github.com/ProjetPP/Deployment/commit/477cebcf863c623f9167a9e80576dc560792b9cf
Could you fix it, please?
Any idea on how to fix java on Travis? It seems to use inconsistent versions for java
and javac
.
nope
It's probably because the build is done with the installed Java 8 and then the run is done with the Java provided by Ubuntu
All checks have passed
:tada:
Dependency: https://github.com/ProjetPP/Scripts/pull/7
These are the required changes to use the CoreNLP server.
I already explained a bit in #148 what were the main issues. CoreNLP does not use the same dependencies as before, so I needed to adapt some code. For the moment, I transform these new dependencies into the older ones (see processForCompatibility). The idea is to adapt our algorithms to these new dependencies in the future.
I realized that our "unit tests" are not unit at all, since a lot of them rely on the output of CoreNLP. This is why I had to rewrite nearly entirely the file data.py. A great idea would be to write better tests...