ProjetPP / PPP-QuestionParsing-Grammatical

Question Parsing module for the PPP using a grammatical approch
GNU Affero General Public License v3.0
33 stars 11 forks source link

CoreNLP server, fix #148 #149

Closed Ezibenroc closed 8 years ago

Ezibenroc commented 8 years ago

Dependency: https://github.com/ProjetPP/Scripts/pull/7

These are the required changes to use the CoreNLP server.

I already explained a bit in #148 what were the main issues. CoreNLP does not use the same dependencies as before, so I needed to adapt some code. For the moment, I transform these new dependencies into the older ones (see processForCompatibility). The idea is to adapt our algorithms to these new dependencies in the future.

I realized that our "unit tests" are not unit at all, since a lot of them rely on the output of CoreNLP. This is why I had to rewrite nearly entirely the file data.py. A great idea would be to write better tests...

Ezibenroc commented 8 years ago

Note: Travis fails because https://github.com/ProjetPP/Scripts/pull/7 is not yet merged.

progval commented 8 years ago

There are some issues after updating bootstrap_corenlp.sh: https://travis-ci.org/ProjetPP/PPP-QuestionParsing-Grammatical/jobs/118461688

Ezibenroc commented 8 years ago

That's because you copied the wrong version of bootstrap_corenlp.sh in the Deployment repository : https://github.com/ProjetPP/Deployment/commit/477cebcf863c623f9167a9e80576dc560792b9cf

progval commented 8 years ago

Could you fix it, please?

Ezibenroc commented 8 years ago

Any idea on how to fix java on Travis? It seems to use inconsistent versions for java and javac.

progval commented 8 years ago

nope

Tpt commented 8 years ago

It's probably because the build is done with the installed Java 8 and then the run is done with the Java provided by Ubuntu

Ezibenroc commented 8 years ago

All checks have passed

yay

progval commented 8 years ago

:tada: