search

Projeto-Pindorama / heirloom-ng

A collection of standard Unix utilities that is intended to provide maximum compatibility with traditional Unix while incorporating additional features necessary today.
http://heirloom-ng.pindorama.dob.jp
Other
24 stars 7 forks source link

New release #41

Open takusuman opened 5 months ago

takusuman commented 5 months ago

@arthurbacci

takusuman commented 4 months ago

@mamccollum I would like to ask you to review this pull-request when you got looser from your assignments at the OpenBSD port and/or any other things you got over there. Arthur got a little busy, so he can't review these any time soon.

arthurbacci commented 4 months ago

suspicious-tools' interval parser should probably be fixed before merging since it may wrongly parse some intervals, despite this most likely not being a major issue

arthurbacci commented 3 months ago

Fun fact: s didn't need to get initialized and you're just making everything worse out of thinking that making dumb changes would make the code more yours

takusuman commented 3 months ago

s didn't need to get initialized and you're just making everything worse out of thinking that making dumb changes would make the code more yours

Blame clang's -Weverything for these.

takusuman commented 3 months ago

I'd like to know what McCollum thinks about changes at rm in https://github.com/Projeto-Pindorama/heirloom-ng/pull/41/commits/491aa1b98c50a9fd26694c2eb01cba967e435224, https://github.com/Projeto-Pindorama/heirloom-ng/pull/41/commits/5f67492f87600afe49cf493de0b6d7c2226b9d25 and https://github.com/Projeto-Pindorama/heirloom-ng/pull/41/commits/b536f5db102d81cf965947f9e22f897e2af614f9.

takusuman commented 3 months ago

I would like to wish a blessed Happy Easter for all of you. See you Monday.

takusuman commented 3 months ago

Of course, (part of) this pull-request fixes #45, so it wasn't closed in vain.

takusuman commented 3 months ago

Calling the cavalry for a review again.

arthurbacci commented 3 months ago

Was the requested review just that?

takusuman commented 3 months ago

Was the requested review just that?

I'm working at other things (wall-impl branch) and I will be merging that at this branch (20240220-fix) later.

takusuman commented 3 months ago

This pull request will be big, just like this release's going to be grand. There's also a fella working on a test suite, so maybe this also get into this.

mamccollum commented 2 months ago

I'd like to know what McCollum thinks about changes at rm in 491aa1b, 5f67492 and b536f5d.

I apologize, I hadn't checked GitHub recently until yesterday and didn't see this. I will see if these as well as the rest of the PR compile on Debian. If/when this PR gets merged, I will get ready to work on moving lots of system-specific things to libcommon, and hopefully that should make the code have the system specific quirks in one place rather than scattered across every C file in here.

mamccollum commented 2 months ago

Alright it compiles, I'll go ahead and see if any of the changed commands have unexpected or erroneous behavior during execution

takusuman commented 2 months ago

Let's go by parts: This pull-request (#41) depends on #49, #50 and #51.

51 is done, so no problem here. But I would like to merge it after #49 and #50.

There's also #47 and #46, but it's too far away of done (and nobody besides me is working on this yet, so I'm afraid this be let for the next release).