search

PromPHP / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
437 stars 96 forks source link

Guzzle 7 Support #11

Closed LukeAbell closed 4 years ago

LukeAbell commented 4 years ago

Could guzzle 7 support be added? Laravel 8 requires it now.

LKaemmerling commented 4 years ago

Hey @LukeAbell,

This library does not require Guzzle anymore (with v2, which is a breaking release because of the removed Pushgateway Support). If you need Pushgateway Support there is a new package. Have a look at the Readme :)

LukeAbell commented 4 years ago

@LKaemmerling can you remove it from the composer.json then? That’s what’s blocking the update for me. https://github.com/PromPHP/prometheus_client_php/blob/1e046c09533733c2988a81bfaaab7d2855d7c2e8/composer.json#L23

LKaemmerling commented 4 years ago

Actually as this is only a requirement for development, it should work without removing it. We use Guzzle for the tests.

How did you require the lib?

LukeAbell commented 4 years ago

@LKaemmerling My project requires guzzle 7 so I think there’s a mismatch in package versions that’s breaking it.

LKaemmerling commented 4 years ago

@LukeAbell i just released v2.1.1 which allows guzzle 7 within the dev dependencies.

LukeAbell commented 4 years ago

@LKaemmerling Thank you!! 💯