I have a custom implementation for Prometheus\RegistryInterface class which since 2.7.0 requires me to implement the method getMetricFamilySamples() with an argument:
PHP Fatal error: Declaration of Javespi\MyCollectorRegistry::getMetricFamilySamples(): array
must be compatible with Prometheus\RegistryInterface::getMetricFamilySamples(bool $sortMetrics = true): array
Hello,
I have a custom implementation for
Prometheus\RegistryInterface
class which since 2.7.0 requires me to implement the methodgetMetricFamilySamples()
with an argument:It looks like the BC was introduced in this PR:
I am going to try to create a pull-request to solve it without losing the new feature.
Cheers