Closed javespi closed 1 year ago
Solves #117
In this PR #108 a breaking change was introduced in these two interfaces:
Prometheus\RegistryInterface
Prometheus\Adapter
Every registry and adapter implementation should pass in methods getMetricFamilySamples and collect a boolean for sorting metrics.
getMetricFamilySamples
collect
Since this was released in a minor version, removing the argument from the interface make it compatible with previous versions.
We still get the new feature introduced but other implementations are not affected.
@javespi thank you. You are correct this is a breaking change. I will release your change asap. Thank you and sorry!
@LKaemmerling what can we do to make this reverted available in the next major?
Thank you!
Solves #117
In this PR #108 a breaking change was introduced in these two interfaces:
Prometheus\RegistryInterface
Prometheus\Adapter
Every registry and adapter implementation should pass in methods
getMetricFamilySamples
andcollect
a boolean for sorting metrics.Since this was released in a minor version, removing the argument from the interface make it compatible with previous versions.
We still get the new feature introduced but other implementations are not affected.