search

PromPHP / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
415 stars 91 forks source link

Avoid breaking change in Adapter and RegistryInterface for sorting metrics #118

Closed javespi closed 1 year ago

javespi commented 1 year ago

Solves #117

In this PR #108 a breaking change was introduced in these two interfaces:

Every registry and adapter implementation should pass in methods getMetricFamilySamples and collect a boolean for sorting metrics.

Since this was released in a minor version, removing the argument from the interface make it compatible with previous versions.

We still get the new feature introduced but other implementations are not affected.

LKaemmerling commented 1 year ago

@javespi thank you. You are correct this is a breaking change. I will release your change asap. Thank you and sorry!

simPod commented 1 year ago

@LKaemmerling what can we do to make this reverted available in the next major?

javespi commented 1 year ago

Thank you!