PromPHP / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
437 stars 96 forks source link

Extract interfaces for Registry and Renderer #16

Closed rdohms closed 4 years ago

rdohms commented 4 years ago

The registry and the renderer are classes that are usually injected by users into their own code, having interfaces for them allow users to mock based on the API and not on the concrete implementation which avoids a common code smell. This also allows better custom implementations if users so desire.

LKaemmerling commented 4 years ago

Thank you!