search

PromPHP / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
423 stars 93 forks source link

Breaking Changes along the way #87

Closed bburnichon closed 2 years ago

bburnichon commented 2 years ago

Hello, I came by this fork migrating a project from using endclothing/prometheus_client_php to latest php 8.1 version. Thanks for your hard work

Along the way, #31 & #53 were merged and considered as adding features and so, bumping minor of the package.

Troubles come from adding method to public interfaces, namely Prometheus\Storage\Adapter. Each of this addition breaks an homemade Storage adapter (with a backend similar to redis but with different limitations).

LKaemmerling commented 2 years ago

Hey,

The Storage Apdater Interface is not part of the Public API. It is part of the private API, and is used to unify the own StorageEngines (Redis & Co). Therefore this is not considered a Breaking Change, as the Collector (which is the Public API) was not changed.