search

PromPHP / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
423 stars 93 forks source link

Learned how to wipe the storage adapter from the registry #89

Closed pachico closed 2 years ago

pachico commented 2 years ago

This addresses issue #88 by allowing to wipe the underlying storage adapter from the registry itself.

LKaemmerling commented 2 years ago

Hey @pachico,

good idea! I like it. Could you please rebase from main and sign your commit? (DCO check)?

pachico commented 2 years ago

Not entirely sure what I'm supposed to do but I'll try :)

pachico commented 2 years ago

In the meanwhile, do you see anything that should be amended in the code changes? Is that test enough? (I think it is but I want to make sure.)

LKaemmerling commented 2 years ago

@pachico For the DCO stuff: https://github.com/PromPHP/prometheus_client_php/pull/89/checks?check_run_id=5881792022

The think the code and the test is fine :)

pachico commented 2 years ago

Got it, thanks, @LKaemmerling , I think now is all set. Do you have any release/tag planning we could count on? I'd really like to work with your repo rather than with a fork :)

LKaemmerling commented 2 years ago

Hey @pachico,

there is only one small test red :) Can you fix it? I would then consider releasing this asap :)

pachico commented 2 years ago

On its way! @LKaemmerling thanks for your patience!

pachico commented 2 years ago

It seems it finally all went through :) Thanks again @LKaemmerling

LKaemmerling commented 2 years ago

Good job! Thanks!

pachico commented 2 years ago

Thanks a lot, @LKaemmerling ! I'm already using it!

image