PromPHP / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
423 stars 93 forks source link

Experiment on Redis-NG Storage without KEYS #99

Closed LKaemmerling closed 1 year ago

LKaemmerling commented 1 year ago

Signed-off-by: Lukas Kämmerling lukas.kaemmerling@hetzner-cloud.de

jquick commented 1 year ago

Tested this out today and its amazing! Works fine (<1sec return) with a large (100-200k) redis DB.

LKaemmerling commented 1 year ago

@jquick thank you! I'm then confident enough that it will work in most cases. I will release it tomorrow :)

jquick commented 1 year ago

@LKaemmerling I may of spoken too soon. We are seeing drastic performance decrees when we started sending with the new lib. We were mistakenly writing with the old Redis and reading with RedisNg. Which was workign for everything but summaries

jquick commented 1 year ago

We have a large amount of summaries and once we started using the new format all requests (even ones on dbs without summeries) were pretty slow. Still digging around.