Promact / md2

Angular2 based Material Design components, directives and services are Accordion, Autocomplete, Collapse, Colorpicker, Datepicker, Dialog(Modal), Menu, Multiselect, Select, Tabs, Tags(Chips), Toast and Tooltip.
http://code.promactinfo.com/md2/
MIT License
379 stars 111 forks source link

Date picker ngmodel not working with type datetime. Value always comes as undefined #224

Closed megamind2301 closed 7 years ago

megamind2301 commented 7 years ago

Bug, feature request, or proposal:

ngmodel variable always gives undefined with type datetime

What is the expected behavior?

ngmodel variable should save value in ISO date format

What is the current behavior?

What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, MD2, OS, browsers are affected?

Angular:4.*.* MD2: 0.0.21 OS: Ubuntu16.10

Is there anything else we should know?

raphaelbadia commented 7 years ago

+1, same angular and md2 version with macOs

megamind2301 commented 7 years ago

This is causing #219 to me. I am setting max min values based on other md2-datepicker's values. And, if their value is not set, max and min doesn't make sense to main md2-datepicker.

dharmeshpipariya-zz commented 7 years ago

@Megamind2301 yes, exactly, if your issue is fixed then we close this issue.

megamind2301 commented 7 years ago

@dharmeshpipariya I request you to work on this bug urgently. My product is about to go live in two days. It will be great help if fixed.

MarcusCalidus commented 7 years ago

@Megamind2301 @dharmeshpipariya I suppose this happens since "change" is not called when you click on the minute hand bubble. As long as you only set the hour hand and click "ok" the change event is called and the value is set.

dharmeshpipariya-zz commented 7 years ago

@Megamind2301 @MarcusCalidus I have fixed this issue in datepicker-dev branch as issue #227 will release soon.

megamind2301 commented 7 years ago

@dharmeshpipariya In v.0.0.24, Datepicker's container='dialog' is not working. Also, I am not able to set startView='year' as year view doesn't exist anymore. In v<=0.0.22, Datepicker's startView is not working.

dharmeshpipariya-zz commented 7 years ago

@Megamind2301 refer API docs of Datepicker, we have replaced container property with touchUi and startView='year' it display year with months.