search

Promact / md2

Angular2 based Material Design components, directives and services are Accordion, Autocomplete, Collapse, Colorpicker, Datepicker, Dialog(Modal), Menu, Multiselect, Select, Tabs, Tags(Chips), Toast and Tooltip.
http://code.promactinfo.com/md2/
MIT License
379 stars 111 forks source link

Datepicker datetime UI displays the wrong information #239

Closed alexmba94 closed 7 years ago

alexmba94 commented 7 years ago

Bug, feature request, or proposal:

When you click the datetime datepicker and get to the clock to select the time, the hours and minutes are displayed incorrectly. Apart from not showing the month names in chrome, already mentioned here for which I still haven't found a solution.

What is the expected behavior?

You expect to see the clock hours from 1 to 12 in the outer circle, and from 13 to 00 in the inner circle, and the minutes from 00 to 55 in multiples of 5. And as you're clicking on the hours and minutes, you can see that what is displayed in the left blue column is exactly what you are choosing.

c1 c2

And when you finished selecting the time, the input displays what you picked correctly. It matches.

c3

What is the current behavior?

This sort of behavior didn't happen before, but as I installed the version 0.0.23 with npm, the hours and minutes are displayed in another order. In the hours, the outer circles goes from 2 to 13 and the inner circle from 14 to 0 followed by another 00. And when you choose the hour, the left column displays one hour more than what you picked when you click on 00. So if you clicked on 00, it displays 01. This doesn't happen for all the other hours. And then the minutes displayed are one minute more than they should be. 5 is 6, 10 is 11 and so on. The worst part is when you finished selecting the time, the input displays one hour and one minute earlier than what you chose. This is very confusing.

Here is an example picking the hour 00 and the minute 06 with the input;

1 2 3

Here is an example picking a different hour:

4 5 6

What are the steps to reproduce?

You can reproduce what I tried to explain here: http://plnkr.co/edit/kpvUGxBqutufayS83RlJ?p=preview

Which versions of Angular, MD2, OS, browsers are affected?

md2 0.0.23 npm 4.2.0 windows 7 angular 4.2.2 angular/cli 1.1.1

pnotarangelo commented 7 years ago

Same issue md2 0.0.23 angular 4.0.1 angular cli 1.0.4

svetq commented 7 years ago

Same issue md2 0.0.24 angular 4.0.0 angular/compiler-cli 4.0.0

janelett commented 7 years ago

same issue

shalugin commented 7 years ago

@dharmeshpipariya Please check PR https://github.com/Promact/md2/pull/243

alexmba94 commented 7 years ago

It still does the same thing though. I installed the latest version through npm and it still does the same thing.

md2 0.0.24 npm 4.2.0 angular 4.2.2 angular/cli 1.1.1

dharmeshpipariya-zz commented 7 years ago

@alexmba94 we have fixed that issue, will release it in next version

shubham-k7 commented 7 years ago

@dharmeshpipariya When is the next release?

dharmeshpipariya-zz commented 7 years ago

yes