search

Promact / md2

Angular2 based Material Design components, directives and services are Accordion, Autocomplete, Collapse, Colorpicker, Datepicker, Dialog(Modal), Menu, Multiselect, Select, Tabs, Tags(Chips), Toast and Tooltip.
http://code.promactinfo.com/md2/
MIT License
379 stars 116 forks source link

DatePicker does not update with ChangeDetectionStrategy.OnPush #266

Open AsherBarak opened 6 years ago

AsherBarak commented 6 years ago

Bug, feature request, or proposal:

BUG

What is the expected behavior?

When using ChangeDetectionStrategy.OnPush, DatePicker bound to component properly shows initial value and updates value after selection.

What is the current behavior?

When using ChangeDetectionStrategy.OnPush, DatePicker bound to component does not show initial value and does not show updated value after selection (bound value is correctly updated)

What are the steps to reproduce?

  1. open this: http://plnkr.co/edit/euy7GjhVGrOHfEpUolIF?p=preview
  2. note date is not displayed in the DatePicker until change detection is triggered (by typing, clicking the selector etc.)
  3. select a new date using Picker
  4. note change is not reflected in the DatePicker until change detection is triggered (by typing, clicking the selector etc.)

What is the use-case or motivation for changing an existing behavior?

Supporting ChangeDetectionStrategy.OnPush

Which versions of Angular, MD2, OS, browsers are affected?

All tested

Is there anything else we should know?

ChenReuven commented 6 years ago

same issue :( is there any WA?

AsherBarak commented 6 years ago

@ChenReuven check out the semi-formal MD implementation at https://github.com/angular/material2. It seems they have catched up to md2.

selaa-online commented 5 years ago

Any WA for this issue?