search

Promact / md2

Angular2 based Material Design components, directives and services are Accordion, Autocomplete, Collapse, Colorpicker, Datepicker, Dialog(Modal), Menu, Multiselect, Select, Tabs, Tags(Chips), Toast and Tooltip.
http://code.promactinfo.com/md2/
MIT License
379 stars 112 forks source link

Angular 8 support #333

Open mtinnes opened 5 years ago

mtinnes commented 5 years ago

Bug, feature request, or proposal:

Refactor any references to DOCUMENT in order to comply with Angular 8 changes

What is the expected behavior?

md2 should compile without error when targeting Angular 8

What is the current behavior?

ERROR in ./node_modules/md2/core/common-behaviors/common-module.js 64:46-54 "export 'DOCUMENT' was not found in '@angular/platform-browser'

What are the steps to reproduce?

Compile an app targeting Angular 8 using md2 components

What is the use-case or motivation for changing an existing behavior?

Compatibility with Angular 8

Which versions of Angular, MD2, OS, browsers are affected?

Angular 8, MD2 0.33

Is there anything else we should know?

DOCUMENT is removed from @angular/platform-browser If you use DOCUMENT from @angular/platform-browser, you should start to import this from @angular/common.

thevirajshelke commented 5 years ago

Facing the same issue when using angular v8

ERROR in ./node_modules/md2/core/common-behaviors/common-module.js 64:46-54
"export 'DOCUMENT' was not found in '@angular/platform-browser'
haskelcurry commented 5 years ago

Same thing. Looking for alternative lib

ravishah94 commented 5 years ago

I want to resolve this issue via PR #335. The PR contains changes with the import of DOCUMENT from tyhr @angular/common instead of @angular/platform-browser to support MD@ with Angular 8 version.

shane-chen commented 5 years ago

Have a look at angular-md2, which migrate md2 to angular8.