Promise do not wait for satisfying locations

[QuentinArnault]

Hi,

I'm not sure if it is a bug or the expected behavior. I create a CLLocationManager promise with a satisfying block. This promise fulfill event if no locations are validated by the satisfying block. I would have expected that the promise will fulfill only if there is at least one satisfying location.

In CLLocationManager+promise.swif we have

    @objc fileprivate func locationManager(_ manager: CLLocationManager, didUpdateLocations locations: [CLLocation]) {
        if let block = satisfyingBlock {
            let satisfiedLocations = locations.filter { block($0) == true }
            seal.fulfill(satisfiedLocations)
        } else {
            seal.fulfill(locations)
        }
    }

I can propose a Pull Requests with something like:

    @objc fileprivate func locationManager(_ manager: CLLocationManager, didUpdateLocations locations: [CLLocation]) {
        if let block = satisfyingBlock,
            let satisfiedLocations = locations.filter { block($0) == true },
            !satisfiedLocations.isEmpty {
            seal.fulfill(satisfiedLocations)
        } else {
            seal.fulfill(locations)
        }
    }

With this implementation, we are waiting for at least one satisfying location.

Regards, Quentin