Wrapping geocodePostalAddress into Promise

[timbms]

I want to propose an addition to wrap geocodePostalAddress available as of iOS 11 into PromiseKit

    /// Submits a forward-geocoding request using the specified postal address.
    @available(iOS 11.0, *)
    public func geocodePostalAddress(_ postalAddress: CNPostalAddress) -> Promise<[CLPlacemark]> {
        return Promise { seal in
            geocodePostalAddress(postalAddress, completionHandler: seal.resolve)
        }
    }

[mxcl]

k, you want to PR? Or I can probably do it today.

[timbms]

You can do it. I haven't done PR on GitHub so far.

[mxcl]

I make no promises, I have very little time for free open source work today.

[nathanhosselton]

@timbms A small, purely additive change like this is the perfect way to get your feet wet with PRs on GitHub! Why not take a stab at it? It's pretty easy:

1. Fork the repo (in this case, our CoreLocation repo)
2. Add the change (it'll go in the CLGeocoder+Promise.swift file)
   • Bonus: Implement a test for it copying our current CLGeocoder tests
3. Open the PR!

[timbms]

OK I take the challenge. Let me do it over the weekend. Tim

On Tue, Feb 20, 2018 at 11:03 PM, Nathan Hosselton <notifications@github.com

wrote:

@timbms https://github.com/timbms A small, purely additive change like this is the perfect way to get your feet wet with PRs on GitHub! Why not take a stab at it? It's pretty easy:

1. Fork the repo (in this case, our CoreLocation repo https://github.com/PromiseKit/CoreLocation)

2. Add the change (it'll go in the CLGeocoder+Promise.swift file https://github.com/PromiseKit/CoreLocation/blob/master/Sources/CLGeocoder%2BPromise.swift)

   • Bonus: Implement a test for it copying our current CLGeocoder tests https://github.com/PromiseKit/CoreLocation/blob/master/Tests/CLGeocoderTests.swift
3. Open the PR!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PromiseKit/CoreLocation/issues/11#issuecomment-367135965, or mute the thread https://github.com/notifications/unsubscribe-auth/AFKRO5EBG18ySa9Z96XqMgsKT3XtvnHIks5tW0ESgaJpZM4SMhWI .

[mxcl]

Closed by #12