search

PromiseKit / CoreLocation

Promises for Swift & ObjC
http://promisekit.org
MIT License
30 stars 29 forks source link

Add SKIP_INSTALL build setting #15

Closed jessedc closed 6 years ago

jessedc commented 6 years ago

I recently integrated PMKCoreLocation into a project manually (no CocoaPods, no Carthage) and noticed an issue when archiving the final product. The issues was the Upload to App Store and Validate buttons are grayed out in the Archives Organizer for my arhives.

This issue is documented by Apple here: https://developer.apple.com/library/content/technotes/tn2215/_index.html and the solution in my case was to make sure SKIP_INSTALL=YES was set on all frameworks, PMKCoreLocation was the only framework I had integrated that did not have this setting set.

This StackOverflow post also talks about the issue as it occurs from xcodebuild -exportArchive.

By default new framework targets have this set to YES.

This pull requests fixes SKIP_INSTALL for the PMKCoreLocation.framework target.

Cheers!

mxcl commented 6 years ago

Good sleuthing, and sorry about this.

mxcl commented 6 years ago

I tagged 3.0.4