search

PromiseKit / CoreLocation

Promises for Swift & ObjC
http://promisekit.org
MIT License
30 stars 29 forks source link

Additional reverse geocoder function #25

Closed BikersDelight closed 5 years ago

BikersDelight commented 5 years ago

Added an additional function to reverse geocode with an optional locale.

mxcl commented 5 years ago

Thanks, our other reverseGeocodeLocation function is named: reverseGeocode(location:) and while I now think this was the wrong decision I think we should be internally consistent.

BikersDelight commented 5 years ago

I used the same implementation as Apple did with CoreLocation, so consistency-wise I’d suggest to use their implementation as well for the other function. Although this introduces a breaking change.

mxcl commented 5 years ago

Although this introduces a breaking change.

Yes, we can do this for PMK7, which is in production, I'll make a note to do so. However we should remain internally consistent with PMK6 for this PR.

BikersDelight commented 5 years ago

I fully agree and will update the PR accordingly.

mxcl commented 5 years ago

Many thanks.

BikersDelight commented 5 years ago

No worries! Done with pleasure...