search

PromiseKit / CoreLocation

Promises for Swift & ObjC
http://promisekit.org
MIT License
30 stars 29 forks source link

Fix issue when trying to promote from whenInUse to always permissions #5

Closed paweljankowski closed 6 years ago

mxcl commented 6 years ago

You marvelous person you.

paweljankowski commented 6 years ago

@mxcl Please hold on with merging this. I've found one case that fix doesn't work...

mxcl commented 6 years ago

np, waiting on the CI anyway. Also I'll try to do a thorough review.

mxcl commented 6 years ago

Please let me know if the fix works.

bruno-rocha-movile commented 6 years ago

Did this end up never being shipped? Looking forward for it, as currently the promotion request's location manager is getting deallocated prematurely and the window dismisses before the user can act 😢

@paweljankowski What is the case that's still broken? Would love to help as I am in a big need of this fix 😞

mxcl commented 6 years ago

If you have a bug report please open a new ticket because as you can see if you click the commit that closed this ticket, we consider this issue fixed and if you click through from the commit you can see that we released a new version of PromiseKit with the fix.

paweljankowski commented 6 years ago

Nope, the fix doesn't work for me :-(

bruno-rocha-movile commented 6 years ago

I saw the commit, I assumed it wasn't shipped because the contents of the commit were not in my CLLocationManager+Promise.swift. But it turns out it was, just written in a different way... Sorry for necro'ing the thread.

mxcl commented 6 years ago

K well, seemingly I didn't understand the bug properly. I don't have an app that promotes from whenInUse to always so one of you guys maybe can provide the fix? I'll open a ticket for the bug.