Songfinish doesn't execute when actually finishing the song

PromyLOPh / pianobar

Console-based pandora.com player

http://6xq.net/pianobar/

Other

1.74k stars 321 forks source link

Songfinish doesn't execute when actually finishing the song #624

Closed ronilaukkarinen closed 7 years ago

ronilaukkarinen commented 7 years ago

Hello! Noticed today I don't get any scrobbles and after thorough investigation it seems stuff inside if event == "songfinish": only executes when switching to next song, not when finishing the song. Forced to scrobble in the beginning in the song (see this), because songstart works just fine. Any thoughts?

ronilaukkarinen commented 7 years ago

Solved this myself. The reason was probably because I had pylast 1.6.0 installed with pip when I should have installed with easy_install to get the latest, 1.8.0. Also, timestamp was incorrect for some reason. Fixed here.