PromyLOPh / pianobar

Console-based pandora.com player
http://6xq.net/pianobar/
Other
1.74k stars 321 forks source link

Clarification for audio_quality = #634

Closed Mibo5354 closed 6 years ago

Mibo5354 commented 6 years ago

Could you put some information on the wiki or the example config for what settings that can actually be put in "audio_quality = {high|192k mp3|???}"

PromyLOPh commented 6 years ago

Have a look at the manpage.

Mibo5354 commented 6 years ago

So does "audio_quality = high" automatically gets the highest quality for Pandora One subscribers?

PromyLOPh commented 6 years ago

I’m not sure, to be honest. Can you apply this patch[1], recompile and send me pianobar’s output (lars+pandora@6xq.net – please remove password and auth token)?

[1] https://gist.github.com/7c0c7c69d0607f3d120efac5fac1b10a

Mibo5354 commented 6 years ago

Done

PromyLOPh commented 6 years ago

Thanks. You’re receiving 64 kbit/s AAC. According to [1] “mobile devices receive a variety of different rates depending on the capability of the device and the network they are on, but never more than 64k AAC+.” Since pianobar uses the mobile API I believe there is nothing I can do to retrieve 192kbps audio files mentioned on the same page.

[1] http://help.pandora.com/customer/portal/articles/1468387-change-your-account-settings#7

albertsj1 commented 6 years ago

@Mibo5354 Take a look at the config here: https://github.com/PromyLOPh/pianobar/blob/master/contrib/config-example#L62

Mibo5354 commented 6 years ago

@albertsj1 What is your point?

albertsj1 commented 6 years ago

Beginning at line 62, it shows the configuration you need to use high quality audio if you have a pandora one account. I just set those same values in my config file and the audio quality sounds great, though I haven't tried the patch suggested above to determine the actual bit rate.

PromyLOPh commented 6 years ago

The comment is a lie.

albertsj1 commented 6 years ago

@PromyLOPh No. My comment is definitely not a lie. My claim that the quality 'seems' great is certainly true. Though, as I indicated in my comment, I didn't confirm using the patch that the bit rate is indeed higher than normal, so this claim should be taken with a grain of salt.

PromyLOPh commented 6 years ago

Sorry, I was refering to the comment in the example config file you linked. It was true a long long time ago, though.

albertsj1 commented 6 years ago

Thanks for clarifying. :) Do those config settings I linked to have any affect at all then?

Mibo5354 commented 6 years ago

The config file should be updated with the new information. Clarifying the maximum quality available is 64k AAC+ not 192k mp3.

PromyLOPh commented 6 years ago

Do those config settings I linked to have any affect at all then? Yes, you can actually lower the quality to 32k if I recall correctly.

The config file should be updated with the new information. It’s on my todo list.

PacAnimal commented 6 years ago

@PromyLOPh With Pandora Premium, Pianobar actually seems to play 192k mp3 now. I verified this by applying the patch from the 4th post above, and seeing that the highQuality audiomap returns stuff like: "highQuality":{"bitrate":"192","encoding":"mp3","audioUrl":"http://t3-3.p-cdn.us/access/6630948428793542401.mp3?version=5&lid=.........

EDIT: Premium, not Plus

PromyLOPh commented 6 years ago

You’re using the default credentials (partner_user/_password)? Can you paste the entire response somewhere?

PacAnimal commented 6 years ago

Sure. Here you go: http://paste.debian.net/1040938/ Yes, I'm using the default credentials.

I've gone into my settings on the Pandora site and enabled high quality, which was disabled after they moved the high quality things from Plus to Premium, which I upgraded to. I am also currently on the 6 month premium trial, but I doubt that affects stuff.

It would be shitty business practice, after all, to give the trial users better quality than the ones who are paying the premium price for the premium service.

PromyLOPh commented 5 years ago

You’re right, that looks alot like 192k mp3. This page now also mentions 192k mp3 on Android, so they must’ve changed it: https://help.pandora.com/s/article/Change-your-Personal-Settings-1519949296224?language=en_US Either way, pianobar plays the highest quality available by default, which should be fine for most people.