search

PromyLOPh / pianobar

Console-based pandora.com player
http://6xq.net/pianobar/
Other
1.74k stars 321 forks source link

Rebased on master: add new thread for player #665

Closed edward-p closed 5 years ago

PromyLOPh commented 5 years ago

Thanks, I’ll review it on the weekend.

edward-p commented 5 years ago

Now we don't need to create our own queue but using av_buffer.

PromyLOPh commented 5 years ago

There is one more thing I’d like to get fixed. Currently the buffer size is unbounded. Buffering a few seconds of decoded audio should be enough. Since we’re working with frames, which all have a timestamp, this shoudn’t be too hard. Do you want to give it a shot? (I was thinking of reusing aoplay_cond for this purpose, but I’m not sure whether that’d introduce a race-condition/possible dead-lock situation).

PromyLOPh commented 5 years ago

Alright, I had a closer look and made a few stylistic changes. Aside from that it is good to go and I’ll merge it unless you have anything you want to add?

Sorry again for all the delays.

edward-p commented 5 years ago

Nothing more to add. I'm ready to merge. Thanks!

PromyLOPh commented 5 years ago

Done. Thank you very much. Good job!