PromyLOPh / pianobar

Console-based pandora.com player
http://6xq.net/pianobar/
Other
1.74k stars 323 forks source link

Unable to pause and resume playback #672

Closed basicide closed 5 years ago

basicide commented 6 years ago

Subject of the issue

When I pause the player for any amount of time and try to resume playback (usually within 60 seconds), the stream fails to continue playing the current song and skips to the next song

Your environment

pianobar 2018.06.22 MacOS 10.12.6 ffmpeg - stable 4.0.2, libav - stable 12.3

config

user = USER@NAME password = PASS autostart_station = #### history = 10 audio_quality = high max_retry = 5 timeout = 300 format_nowplaying_song = %t by %a on %l%r%@%s format_nowplaying_station = Station %n format_list_song = %i) %a - %t%r

Steps to reproduce

Play a song on any station, pause the song for about 10-15 seconds, resume song

Expected behaviour

Song should continue playing as normal.

Actual behaviour

Song plays for ~10 seconds, then skips to next song

PromyLOPh commented 5 years ago

We could try marking the shared variables volatile, see this patch: https://gist.github.com/PromyLOPh/77132be527ac9709ff2ac2310df29200 But it shouldn’t be required.

basicide commented 5 years ago

No change after applying the patch. But it is playing successfully again, so we can mark this issue closed. Thanks for all your help with this.

PromyLOPh commented 5 years ago

Odd. Anyway, thanks for your patience while debugging this issue.