search

PromyLOPh / pianobar

Console-based pandora.com player
http://6xq.net/pianobar/
Other
1.74k stars 320 forks source link

Add volume change event. #698

Open CoderRing28 opened 4 years ago

CoderRing28 commented 4 years ago

Include volume in Event Command information

PromyLOPh commented 4 years ago

Can you motivate your pull request? Why do you need such an event?

CoderRing28 commented 4 years ago

This will allow us to obtain the current volume level and track it as it is changed. It will facilitate setting adequate/preferred volume levels. Currently there is no feedback as to what the current setting is and the user needs to wait for audible feedback before knowing they have reached the desired level. This can also help users set max thresh hold for volume to prevent clipping or audio distortions from exceeding hardware capabilities due to slow audio feedback.

I've got these changes in my build and they work well. The user interface displays the current volume so I can more quickly get to desired states. Whether or not you guys approve/merge the request will not impact me, but since I am benefiting from your tool I thought I would contribute the tweaks that I made.

cheers

PromyLOPh commented 4 years ago

Currently there is no feedback as to what the current setting […] This is completely intentional and I recommend not using pianobar’s volume control, since it’s software-based and thus increasing the volume will always cause clipping while decreasing it will reduce dynamic range. Leave it at 0 and instead use hardware-based volume control or – if you must – pulseaudio.

CoderRing28 commented 4 years ago

In a lot of usage situations the user doesn't have direct access to the hardware controls. I have found the pianobar volume controls useful in a certain range. The provided change helped me to better remotely control the volume.  Like i said, though, i am set.  If this change doesn't fit your intended paradigm, then I understand. Sent from Yahoo Mail on Android

On Fri, Jul 3, 2020 at 10:18 AM, لارس · Lars‮notifications@github.com wrote:

Currently there is no feedback as to what the current setting […] This is completely intentional and I recommend not using pianobar’s volume control, since it’s software-based and thus increasing the volume will always cause clipping while decreasing it will reduce dynamic range. Leave it at 0 and instead use hardware-based volume control or – if you must – pulseaudio.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.