Notify the user if they have the caps lock on and are trying to issue a valid command

PromyLOPh / pianobar

Console-based pandora.com player

http://6xq.net/pianobar/

Other

1.73k stars 323 forks source link

Notify the user if they have the caps lock on and are trying to issue a valid command #704

Closed ijustlovemath closed 3 years ago

ijustlovemath commented 3 years ago

Sometimes I forget I have the caps lock on and hit 'N' only for nothing to happen; short of modifying actual dispatch settings to duplicate the callbacks, I think this is a fair compromise in terms of user experience + leaving those shortcuts open for future use

PromyLOPh commented 3 years ago

I’m not convinced this is an actual problem we need to address. For password input I get the idea, but we already have instant feedback for pretty much all actions, i.e. nothing happens → you pressed the wrong key.

ijustlovemath commented 3 years ago

I agree with that behavior for unsupported keys, but if it just so happens to be the uppercase of a supported key, it might be nice to have! But also respect your judgement here, it's your project.