search

Proof-Of-Chaos / website

https://proofofchaos.app
MIT License
2 stars 2 forks source link

NFT ids #73

Open niklasp opened 1 year ago

niklasp commented 1 year ago

Currently unique NFT ids are generated from the index of the vote in getTxsForVotes. That obviously doesn't work when minting to an already existing collection. We need to think about a unique id for collection NFTs of type u32.

E.g. ${refId}${1-n for rarity index}{voteIndex}

or query nfts.collection to get the number of items and start from numItems + 1

Bildschirmfoto 2023-07-22 um 00 57 15

Ideas?

gabrieljaegerde commented 1 year ago

querying the nfts.collection is not an option as there might be referenda in the queue that assign certain IDs already.

Technically also there could be multiple nft sendouts for the same ref. It's important that we consider that too.

Perhaps we should also think about a way to create new collections for each ref.

niklasp commented 1 year ago

New collections i will build, the ui is already ready in a way. still i think when we as poc want to start we should mint to a default collection (and maybe encourage others). I imagine having 10s of rewards collections with only 3 different rarities will clutter all NFT marketplaces UIs like crazy and make it even harder for people to follow / organize. I liked how it was done before.