search

Proof-Of-Humanity / proof-of-humanity-web

The Proof Of Humanity web application.
https://app.proofofhumanity.id
MIT License
81 stars 40 forks source link

Remove metadata from user uploads #295

Open eccentricexit opened 3 years ago

luiandresgonzalez commented 3 years ago

@clesaege why has this changed to low priority?

aahna-ashina commented 2 years ago

Related forum thread: https://gov.proofofhumanity.id/t/better-info-on-privacy-during-registration/1363

mmiguerodriguez commented 2 years ago

This should be pushed to priority: high already.

Why? #486 is delayed due to "GDPR issues".

What about videos already uploaded which are also being saved on kleros ipfs and is already public knowledge that geolocation wasn't removed?

More info regarding GDPR and personal data can be found on gpdr-info website

aahna-ashina commented 2 years ago

What about videos already uploaded which are also being saved on kleros ipfs and is already public knowledge that geolocation wasn't removed?

@mmiguerodriguez For privacy protection, we should remove the metadata from those images and videos already uploaded to IPFS. I don't know if IPFS has a mechanism for deleting files. I'll study how it works, and get back to you.

AndreiMVP commented 2 years ago

Tried piexifjs to remove EXIF, but it only works for JPEG and JPG. Couldn't find a client-side library that works for the PoH supported formats. There is gps-metadata-remover, but it uses filesystem read and write functions.

mmiguerodriguez commented 2 years ago

@AndreiMVP

I have found some libraries that may be useful, never really had time to test them but it would be nice if you could try them out. For videos: https://github.com/Kagami/ffmpeg.js https://github.com/bgrins/videoconverter.js (unmaintained) https://superuser.com/questions/441361/strip-metadata-from-all-formats-with-ffmpeg (related)

I believe some kind of ffmpeg-like in-browser library would fit really well.

For images: ~I believe this library removes metadata from all formats allowed on a PoH submission (jpeg/jpg/png). https://github.com/xoeye/gps-metadata-remover It says it also removes some video formats metadata but I think an in-browser ffmpeg would be better for this.~

Edit: Just saw that it uses filesystem read/write functions, I can search for another one and reply again if I find any.

Hope you could have a look and maybe try them out.

bilinkis commented 2 years ago

Fixed on https://github.com/bilinkis/proof-of-humanity-web It's live on https://proofofhumanity.org