Closed tarsius closed 7 years ago
For the Proof General Debian package I removed mmm-mode already (because it is packaged separately in Debian). The patch was rather simple:
Description: don't install contrib/mmm mmm-mode is available as package and added to the dependencies Author: Hendrik Tews hendrik@askra.de --- a/Makefile +++ b/Makefile @@ -34,7 +34,7 @@ DEST_PREFIX=$(DESTDIR)/usr
PROVERS=coq hol-light -OTHER_ELISP=generic lib contrib/mmm +OTHER_ELISP=generic lib ELISP_DIRS=${PROVERS} ${OTHER_ELISP} ELISP_EXTRAS= EXTRA_DIRS = images
Do you want me to submit a pr?
Also there are two more bundled libraries maths-menu.el
and texi-docstring-magic.el
. But both are not available from Melpa yet. I am gonna look into that a bit more.
Thanks so much @tarsius for this. Dropping mmm was indeed on the roadmap, so this will help. I'll try to look into this this week-end, if no one beats me to it. I also expect that you'll find https://github.com/ProofGeneral/PG/pull/157 relevant to this.
maths-menu
has diverged. You should try to get your changes merged upstream.texi-docstring-magic
isn't maintained anymore. I am going to add it to the Emacsorphanage, apply your changes, and then add that to Melpa and the Emacsmirror.Thanks; we should also check whether these are still useful in PG.
I'll wait until you have done that before I move forward.
Thanks! This week end for sure.
N.B.: I'll mirror whatever changes occur in the PG/xml fork.
On Thu, Mar 16, 2017 at 3:49 PM, Clément Pit-Claudel < notifications@github.com> wrote:
Thanks! This week end for sure.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ProofGeneral/PG/issues/171#issuecomment-287171429, or mute the thread https://github.com/notifications/unsubscribe-auth/ACJAKGQr-MHB1EtSSGvwlz4H5e-Yyv-zks5rmZJhgaJpZM4Mflh7 .
I'm removing mmm from PG/xml, although it doesn't seem to have happened in the master branch yet.
Can you do it in master too, and merge back?
Should I remove ML4PG in master, too?
I've created PR #185, so others can validate these changes.
Once that's merged, I'll merge back to PG/xml.
Closing, mmm has been removed.
Thanks!
As part of my work on the Emacsmirror I try to resolve feature conflicts between mirrored packages. I noticed that PG bundles
mmm-mode
. That package is now maintained in its own right again (https://github.com/purcell/mmm-mode) and you should remove the bundled copy.The two versions seem to be very similar. Most differences are only whitespace fixes and dropped XEmacs support. There are also some new libraries. Below you can see the diff.
I would have created a pr to remove the bundled libraries, but I suspect you might also have to make some small adjustments to the build scripts, to teach them that
mmm-mode
is no longer bundled.