ProofGeneral / PG

This repo is the new home of Proof General
https://proofgeneral.github.io
GNU General Public License v3.0
483 stars 85 forks source link

run test and compile-test jobs in CI with different emacs versions #538

Open hendriktews opened 3 years ago

hendriktews commented 3 years ago

@erikmd : Do you have plans/ideas about running the coq related tests in CI with different emacs versions?

After looking a bit around I see three options:

hendriktews commented 3 years ago

I have Dockerfile's now for creating docker images with arbitrary coq and emacs combinations. They are based on the coqorg/coq images and add emacs via nix. Using these images in CI would have caught #534. @erikmd : Do you have any opinion about creating a PR for those Dockerfile's in the coq-community/docker-coq repo?

erikmd commented 3 years ago

Hi @hendriktews, thanks a lot for looking at this!

and sorry for being less responsive… the Spring term is going to resume on Jan 4th so I'm extremely busy these days.

Some first comments:

maybe we could arrange some video call (e.g. from mid-January) to discuss this topic further and implement this idea?

erikmd commented 3 years ago

BTW−FYI, I had already created (to save the name) a Docker Hub organization at URL https://hub.docker.com/u/proofgeneral, so we may use it for hosting some of these images :)

hendriktews commented 3 years ago

and sorry for being less responsive… the Spring term is going to resume on Jan 4th so I'm extremely busy these days.

No problem!

* basing the images upon coqorg/coq then adding emacs thanks to Nix seems a nice strategy;

I use two stages of course. The first adds nix and the second adds emacs. nix seems to have only nox emacs versions, but this is probably fully sufficient.

* but I wouldn't suggest to add emacs readily "upstream" in coqorg/coq because:

Sure.

* however, I guess the [docker-keeper] infrastructure I now use to maintain coqorg/coq could be used

OK, I'll try this.