search

ProofSuite / OrFeed

DeFi & Distributed Data Service Aggregator
https://www.orfeed.org
Apache License 2.0
241 stars 152 forks source link

added the voting contract #53

Closed mul1sh closed 4 years ago

mul1sh commented 4 years ago

Fixes #52

mikedeshazer commented 4 years ago

@mul1sh thanks for sharing! per the new file schema, best place for this file would probably be in /contracts/examples/Provider contracts

mul1sh commented 4 years ago

@mikedeshazer done 🙂

mikedeshazer commented 4 years ago

@mul1sh biggest thing that sticks out is the voting period. As per issue this should be set in days so a user can easily set. The function we have now is fine however, could we add one function in which a user specifies a uint of the days from now to start and a period of days duration, as so its easy to calculate, and set by the owner?

mul1sh commented 4 years ago

Done 🙂

mikedeshazer commented 4 years ago

@mul1sh will test over the weekend but will close the issue . Will merge by Monday once we can confirm all is well. Thanks!

mul1sh commented 4 years ago

@mikedeshazer ok thanks

mul1sh commented 4 years ago

Any feedback on this one yet @mikedeshazer

mikedeshazer commented 4 years ago

Looks great! Looking forward to checking out the leveraged position contract as well!