ProofSuite / OrFeed

DeFi & Distributed Data Service Aggregator
https://www.orfeed.org
Apache License 2.0
241 stars 152 forks source link

OrFeed Testnet Deployments Out-Of-Date #69

Closed mikedeshazer closed 3 years ago

mikedeshazer commented 4 years ago

Let's admit: Various aspects of this codebase are a mess, as it was conceived during a hackathon and then iterated on.

But it's an amazing opportunity in the art of the renovation, as we proceed. This renovation starts with tests and testnet redeployments. The goal is to redeploy the Rinkeby and Kovan contracts for the main contract (orfeed.sol), linking it to the appropriate testnet contracts for Kyber, Uniswap, Synthetix, Chainlink etc, and then deploying the proxy OrFeed contracts that the main contract interfaces with (a lot) on testnets as well (the registry system, events registry, premium/advanced data feeds, arbitrage smart contracts)

Basically, the functionality that you can observe and test here: https://www.orfeed.org/explorer using examples from orfeed.org/docs will work the same on testnet as they do on mainnet/the current explorer.

The best part, explaining how all these link together and work, as a part of a new README section! This is a lot to ask, and the bounty is really meant for someone who can feel the mission vs. just-another-bounty sort of thing.

What is this and how exactly does it work? Here are a series of videos that pretty much take you on a tour as OrFeed tries to aggregate oracles for various DeFi projects into one cohesive, standardized, consumable protocol. https://www.youtube.com/playlist?list=PLkA8kdGfX8nYGlfS40BYY43Hdzy3ZzC8H

Have questions? Here's the discord (https://discord.gg/byCPVsY). In the issues channel, maybe someone has already even wondered a similar thing. Feel free to reach out!

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 month, 2 weeks from now. Please review their action plans below:

1) yashnaman has been approved to start work.

I can do as required. I am familiar with the project. 2) yashnaman has applied to start work _(Funders only: approve worker | reject worker)_.

I can do as required. I am familiar with the project. 3) davexlr has applied to start work _(Funders only: approve worker | reject worker)_.

i've worked on similar projects like this. I can do it

Learn more on the Gitcoin Issue Details page.

vporton commented 4 years ago

Are token addresses in Rinkeby/ and Kovan/ like

    freeRateTokenSymbols['DAI'] = 0x2448eE2641d78CC42D7AD76498917359D961A783;

already correct? Or each address needs to be checked?

vporton commented 4 years ago

Is it a good idea to autogenerate all of orfeed.sol, Rinkeby/orfeed.sol and Kovan/orfeed.sol from one source file?

If yes, what to use to generate it? make?

mikedeshazer commented 4 years ago

@vporton yes I believe, for example, the new DAI/SAI was after the original deployment, so yes, those would need to be updated. Also, regarding the autogeneration, whatever works :)

vporton commented 4 years ago

@vporton yes I believe, for example, the new DAI/SAI was after the original deployment, so yes, those would need to be updated. Also, regarding the autogeneration, whatever works :)

Where to gather the information about the contract addresses?

mikedeshazer commented 4 years ago

@vporton exactly. Etherscan/each project's website has their rinkeby and other testnet contract data. That is why this is so difficult to do at the moment as far as testnets go...

vporton commented 4 years ago

There exists multiple versions of testnet DAI. I have no idea which of them is the "true".

I will stop work.

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

@yashnaman Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Cancelled


The funding of 0.8 ETH (187.45 USD @ $234.31/ETH) attached to this issue has been cancelled by the bounty submitter

rori4 commented 4 years ago

are the testnet contracts going to be updated?